Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AppFrame): top bar changes and nav item interface update #1374

Merged
merged 15 commits into from
Oct 3, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Oct 1, 2024

Resolves: #{issue-number}

Description

Update for the NavigationTopBarItem interface, solving the TS issue with passing the additional anchor props.
Changes in the NavigationTopBar in the UI and smaller resolutions behavior.
Added additional docs describing guide how to build top bar alerts mechanism. (guidelines)

Storybook

https://feature-app-frame-fixes--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

 and nav item interface changes
@marcinsawicki marcinsawicki added the bug Something isn't working label Oct 1, 2024
@marcinsawicki marcinsawicki added this to the Cycle #10 milestone Oct 1, 2024
@marcinsawicki marcinsawicki self-assigned this Oct 1, 2024
@marcinsawicki marcinsawicki marked this pull request as ready for review October 1, 2024 09:20
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit 79063e4 into main Oct 3, 2024
5 checks passed
@marcinsawicki marcinsawicki deleted the feature/app-frame-fixes branch October 3, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants