Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AppFrame): nav bar scroll fix and sub nav chevron update #1414

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Oct 21, 2024

Resolves: #{issue-number}

Description

Side navigation group chevron color update for closed state.
Fix for horizontal scroll after hovering main nav item.
Change useAppFrame listener to remove after invoke.

Storybook

https://feature-app-frame-bug-fixes--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Oct 21, 2024
@marcinsawicki marcinsawicki added this to the Cycle #10 milestone Oct 21, 2024
@marcinsawicki marcinsawicki self-assigned this Oct 21, 2024
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit a308472 into main Oct 22, 2024
5 checks passed
@marcinsawicki marcinsawicki deleted the feature/app-frame-bug-fixes branch October 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants