Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): fixing animated label logic #1422

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(Button): fixing animated label logic #1422

wants to merge 2 commits into from

Conversation

VadymBezpalko
Copy link
Contributor

@VadymBezpalko VadymBezpalko commented Nov 4, 2024 •
edited by github-actions bot
Loading

Resolves: #1364

Description

Using SCSS variables to pass calculated content width from JS to SCSS, so it will be animated relying only on CSS pseudoclasses.

Storybook

https://feature-1364--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@VadymBezpalko VadymBezpalko self-assigned this Nov 4, 2024
vladko-uxds
vladko-uxds approved these changes Nov 6, 2024
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@marcinsawicki marcinsawicki Awaiting requested review from marcinsawicki

Assignees

@VadymBezpalko VadymBezpalko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Button] - animated button bug
2 participants
@VadymBezpalko @vladko-uxds