-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Typography): new semi-bold variant #1439
Conversation
WalkthroughThe changes introduce a new optional property Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/react-components/src/components/Typography/Text.tsx (1)
25-26
: Enhance JSDoc documentation for semiBold propertyAdd details about the font-weight value (500) and usage guidelines.
- /** Optional prop to set the semi-bold */ + /** Optional prop to set semi-bold weight (500). Use for moderate emphasis without the heaviness of bold. */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
packages/react-components/src/components/Typography/Text.tsx
(3 hunks)packages/react-components/src/components/Typography/Typography.module.scss
(1 hunks)packages/react-components/src/stories/foundations/Typography/components/TextExamples.tsx
(1 hunks)
🔇 Additional comments (3)
packages/react-components/src/stories/foundations/Typography/components/TextExamples.tsx (1)
15-17
: LGTM! Well-integrated example of the new semiBold variant.
The example is logically placed between regular and bold variants, providing clear documentation of the new feature.
Let's verify the visual implementation:
packages/react-components/src/components/Typography/Text.tsx (1)
45-45
: LGTM!
Default value and placement are consistent with existing patterns.
packages/react-components/src/components/Typography/Typography.module.scss (1)
165-167
: Well-structured semi-bold variant implementation!
The new semi-bold modifier follows the established patterns and uses appropriate font weight that aligns with the design system's typography scale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves: #1419
Description
New
semiBold
props forText
component.Storybook
https://feature-1419--613a8e945a5665003a05113b.chromatic.com
Checklist
Obligatory:
Summary by CodeRabbit
New Features
semiBold
property for theText
component, allowing for semi-bold text styling..paragraph--semi-bold
modifier in styles for enhanced typography options.TextExamples
to showcase the new semi-bold text variant.Bug Fixes
Documentation