Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): fix Button text wrapping #1506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

JoannaSikora
Copy link
Contributor

@JoannaSikora JoannaSikora commented Jan 30, 2025

Resolves: #1499

Description

This pull request includes style adjustments to the Button component. These changes ensure better layout and text wrapping handling within the button.

  • Added white-space: nowrap to prevent text inside the button from wrapping onto multiple lines.

Example from AA:
Before:

Screenshot 2025-01-30 at 08 00 40 Screenshot 2025-01-30 at 08 35 56 Screenshot 2025-01-30 at 08 37 22

After:

Screenshot 2025-01-30 at 08 01 04 Screenshot 2025-01-30 at 08 35 46 Screenshot 2025-01-30 at 08 37 43

Storybook

https://feature-1499-2--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

Summary by CodeRabbit

  • Style
    • Updated Button component styles to prevent text wrapping and maintain button size in flex containers.

Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Walkthrough

The changes introduce a new property to the default mixin in the base.scss file for the Button component. The addition of white-space: nowrap; prevents the text within the button from wrapping to the next line, ensuring that the button's text remains on a single line regardless of its length.

Changes

File Change Summary
packages/react-components/src/components/Button/styles/base.scss Added white-space: nowrap; to the default mixin

Assessment against linked issues

Objective Addressed Explanation
Prevent text wrapping [#1499]
Maintain button minimum width [#1499] The changes do not ensure the button maintains a minimum width as required.

Suggested reviewers

  • vladko-uxds
  • marcinsawicki

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c619672 and 5bff045.

📒 Files selected for processing (1)
  • packages/react-components/src/components/Button/styles/base.scss (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-components/src/components/Button/styles/base.scss
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: chromatic-deployment
  • GitHub Check: build

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JoannaSikora JoannaSikora marked this pull request as ready for review January 30, 2025 07:39
@JoannaSikora JoannaSikora added the bug Something isn't working label Jan 30, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
packages/react-components/src/components/Button/styles/base.scss (2)

5-5: LGTM! Consider documenting layout implications.

The flex-shrink: 0 addition effectively prevents unwanted button shrinking, but layouts requiring flexible buttons might need a modifier class.


18-18: Consider overflow handling for long text.

While white-space: nowrap fixes wrapping, very long button text might overflow. Consider adding text-overflow: ellipsis and max-width properties.

  white-space: nowrap;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ max-width: 100%;
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca526ca and c619672.

📒 Files selected for processing (1)
  • packages/react-components/src/components/Button/styles/base.scss (2 hunks)

Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] - Fix text wrapping
3 participants