-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Button): fix Button text wrapping #1506
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce a new property to the Changes
Assessment against linked issues
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/react-components/src/components/Button/styles/base.scss (2)
5-5
: LGTM! Consider documenting layout implications.The
flex-shrink: 0
addition effectively prevents unwanted button shrinking, but layouts requiring flexible buttons might need a modifier class.
18-18
: Consider overflow handling for long text.While
white-space: nowrap
fixes wrapping, very long button text might overflow. Consider addingtext-overflow: ellipsis
andmax-width
properties.white-space: nowrap; + overflow: hidden; + text-overflow: ellipsis; + max-width: 100%;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves: #1499
Description
This pull request includes style adjustments to the
Button
component. These changes ensure better layout and text wrapping handling within the button.white-space: nowrap
to prevent text inside the button from wrapping onto multiple lines.Example from AA:
Before:
After:
Storybook
https://feature-1499-2--613a8e945a5665003a05113b.chromatic.com
Checklist
Obligatory:
Summary by CodeRabbit