#341 Reorganize Badge component to reflect Figma designs #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraczyk
requested review from
marcinsawicki,
martagranisz,
MichalPaszowski and
TomaszRatajczyk
AlithAnar
approved these changes
Jul 26, 2022
marcinsawicki
approved these changes
Jul 26, 2022
mreszke
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #341
Description
The original issue assumed only the need to apply some styles, however, the component requires some bigger refactor in order to handle various variants. Changes applied:
kindprop instead ofsecondarybooleansizeto handle 3 casestypeto automatically handlealertanddotvariants. I've ignorednew-messageandextendedas for now I believe other forms of content should be handled externally.Storybook