Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#339 Apply missing tokens to Input and TagInput components #364

Merged
merged 1 commit into from
Jul 27, 2022
Merged

#339 Apply missing tokens to Input and TagInput components #364

merged 1 commit into from
Jul 27, 2022

Conversation

sgraczyk
Copy link

Resolves: #339

Description

Initially, the task assumed only adding missing background color tokens, however, I've also found out it requires some work around stories and other styles. Here's what changed:

  • Added background and placeholder color tokens for Input
  • Added background and disabled color tokens for TagInput
  • Added disabled prop to InputProps
  • Reorganized stories to cover sizes and states of Input components

Storybook

Checklist

Obligatory:

  • Self-review
  • Unit & integration tests
  • Storybook cases
  • Design review
  • Functional (QA) review

Optional:

  • Accessibility cases (keyboard control, correct HTML markup, etc.)

@sgraczyk sgraczyk linked an issue Jul 27, 2022 that may be closed by this pull request
[Input][TagInput] Missing background design tokens #339
Closed
@sgraczyk sgraczyk requested a review from kstvsko July 27, 2022 09:14
@sgraczyk sgraczyk requested a review from a team July 27, 2022 11:24
@sgraczyk sgraczyk merged commit 9a5b687 into v1 Jul 27, 2022
@sgraczyk sgraczyk deleted the feature/339 branch July 27, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreszke mreszke mreszke approved these changes

@marcinsawicki marcinsawicki marcinsawicki approved these changes

@AlithAnar AlithAnar AlithAnar approved these changes

@TomaszRatajczyk TomaszRatajczyk Awaiting requested review from TomaszRatajczyk

@martagranisz martagranisz Awaiting requested review from martagranisz

@MichalPaszowski MichalPaszowski Awaiting requested review from MichalPaszowski

@kstvsko kstvsko Awaiting requested review from kstvsko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Input][TagInput] Missing background design tokens
4 participants
@sgraczyk @AlithAnar @marcinsawicki @mreszke