#345 Spacing variables for the css usage #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why aren't we using |
Closed
sgraczyk
reviewed
Jul 28, 2022
sgraczyk
reviewed
Jul 28, 2022
| @@ -1,4 +1,7 @@ | |||
| @use './themes/legacy'; | |||
| @use './themes/light'; | |||
| @use './themes/dark'; | |||
| @use './spacing/spacing'; | |||
There was a problem hiding this comment.
how about?:
Suggested change
| @use './spacing/spacing'; | |
| @use './foundations/spacing'; |
sgraczyk
reviewed
Jul 28, 2022
| @@ -1,6 +1,7 @@ | |||
| import './index.scss'; | |||
|
|
|||
| export { DesignTokens } from './themes/designTokens'; | |||
| export { SpacingTokens } from './spacing/spacingTokens'; | |||
There was a problem hiding this comment.
Enumerations (even realized as consts) should have a singular form.
Suggested change
| export { SpacingTokens } from './spacing/spacingTokens'; | |
| export { SpacingToken } from './foundation/spacing-tokens'; |
sgraczyk
reviewed
Jul 28, 2022
| @@ -1,6 +1,7 @@ | |||
| import './index.scss'; | |||
|
|
|||
| export { DesignTokens } from './themes/designTokens'; | |||
There was a problem hiding this comment.
We could fix this also
Suggested change
| export { DesignTokens } from './themes/designTokens'; | |
| export { DesignToken } from './themes/design-token'; |
There was a problem hiding this comment.
👍 But we need to remember to include this as (small) breaking change in release docs, as we use DesignTokens enum in another app.
sgraczyk
reviewed
Jul 28, 2022
sgraczyk
reviewed
Jul 28, 2022
| @@ -0,0 +1,16 @@ | |||
| export const SpacingTokens = { | |||
There was a problem hiding this comment.
Alternatively SPACING_TOKENS, hard to say what's our approach here, as it seems more of a enumeration than a set of data.
Suggested change
| export const SpacingTokens = { | |
| export const SpacingToken = { |
sgraczyk
approved these changes
Jul 28, 2022
kstvsko
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #345
Description
Scss variables of spacing, to the use in styling for components.
Storybook
Checklist
Obligatory:
Optional: