[ActionMenu] - fixes after RefreshUI tests #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadymBezpalko
approved these changes
Sep 12, 2023
| </button> | ||
| </li> | ||
| ))} | ||
| {options.map((o, i) => getOptionElement(o, i))} |
There was a problem hiding this comment.
Suggested change
| {options.map((o, i) => getOptionElement(o, i))} | |
| {options.map(getOptionElement)} |
| const handleItemClick = (itemOnClick: () => void) => { | ||
| itemOnClick(); | ||
| const handleItemClick = (itemOnClick?: () => void) => { | ||
| itemOnClick && itemOnClick(); |
There was a problem hiding this comment.
Suggested change
| itemOnClick && itemOnClick(); | |
| itemOnClick?.(); |
|
|
||
| if (!keepOpenOnClick) { | ||
| setIsVisible(false); | ||
| } | ||
| }; | ||
|
|
||
| const getOptionElement = (option: IActionMenuOption, index: number) => { |
There was a problem hiding this comment.
I'd suggest to put this element as a separate component into a components folder
vladko-uxds
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the trigger implementation, it uses the default
buttonelement, which wraps the element, with the possibility to modify it bytriggerClassNameprop.Also added
groupHeaderprop tooptionsto better group menu elements.Storybook
https://feature/action-menu-trigger-fix--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-actionmenu--keep-open-on-item-click
Checklist
Obligatory:
livechat/design-system)