-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add API validation to workflow #101
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thank you
@bcherry i unexported some things and set some others to be internal, please have a look and make sure everything is as it should be (notably unexported api_proto on openai) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it
lukas is working on a better implementation using api-extractor, i'm waiting for that instead |
also delete plugin and tokenize which aren't being used for anything rn
this doesn't use api-extractor, because i've still got no clue how that works. instead it runs TypeDoc validator (with some settings tweaked for sanity).
this PR marked as draft because currently none of openai is documented, and neither is STT/TTS. will come back to this PR once everything else is finalized-ish in terms of API, to minimize merge conflicts later down the line.