Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add API validation to workflow #101

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add API validation to workflow #101

wants to merge 4 commits into from

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Oct 7, 2024

this doesn't use api-extractor, because i've still got no clue how that works. instead it runs TypeDoc validator (with some settings tweaked for sanity).

this PR marked as draft because currently none of openai is documented, and neither is STT/TTS. will come back to this PR once everything else is finalized-ish in terms of API, to minimize merge conflicts later down the line.

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 82532de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you

@nbsp nbsp marked this pull request as ready for review October 9, 2024 07:48
@nbsp nbsp requested a review from bcherry October 9, 2024 07:48
@nbsp
Copy link
Member Author

nbsp commented Oct 9, 2024

@bcherry i unexported some things and set some others to be internal, please have a look and make sure everything is as it should be (notably unexported api_proto on openai)

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@nbsp
Copy link
Member Author

nbsp commented Oct 15, 2024

lukas is working on a better implementation using api-extractor, i'm waiting for that instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants