Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(treewide): native CommonJS #176

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore(treewide): native CommonJS #176

wants to merge 4 commits into from

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Nov 21, 2024

this still doesn't work. also the example i've been testing with, multimodal_agent.js, doesn't compile right, and needs tsx to run.

pnpm exec tsx src/multimodal_agent.ts dev --log-level debug

see that even though there are debug logs and plain console logs in job_main, none of them show up, and something gets stuck there. perhaps an unresolvable promise detection that exits with 13 without telling us? unsure.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 69b3968

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

this still doesn't work. also the example i've been testing with,
multimodal_agent.js, doesn't compile right, and needs tsx to run.

    pnpm exec tsx src/multimodal_agent.ts dev --log-level debug

see that even though there are debug logs and plain console logs, none
of them show up, and something gets stuck there. perhaps an unresolvable
promise detection that exits with 13 without telling us? unsure.
@nbsp
Copy link
Member Author

nbsp commented Nov 22, 2024

now builds and runs, with following caveats:

  • ts-mutex has to be vendored with type: module removed (currently it serves ESM on both mjs and js)
  • log fails, despite running off of same exact file, will look into it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant