Shubhra/ajs 41 remove hard coding of audio input sample rate #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3635fb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Shubhrakanti
commented
Jun 27, 2025
Comment on lines
+145
to
+148
| session.start({ | ||
| agent: routerAgent, | ||
| room: ctx.room, | ||
| }); |
There was a problem hiding this comment.
@toubatbrian feel like this is cleaner?
Shubhrakanti
commented
Jun 27, 2025
Comment on lines
+101
to
+102
| this.inputOptions = { ...DEFAULT_ROOM_INPUT_OPTIONS, ...inputOptions }; | ||
| this.outputOptions = { ...DEFAULT_ROOM_OUTPUT_OPTIONS, ...outputOptions }; |
There was a problem hiding this comment.
we do this instead of inputOptions = DEFAULT_ROOM_INPUT_OPTIONS in the constructor because we want to override the defaults with any options specified by the user.
|
Also finishes AJS-55 |
Shubhrakanti
deleted the
shubhra/ajs-41-remove-hard-coding-of-audio-input-sample-rate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RoomIO input and output options. Will actually apply the flags in a later PR.