-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set USE_DOCSTRING as default for ai_callable #1266
Conversation
🦋 Changeset detectedLatest commit: 8d8b11b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is rather annoying tho as a requirement.. wdyt about just making that the default behavior?
if no explicit description is provided, it'll use docstring. if docstring isn't set, it raises
I think that makes sense, most people will explicitly set a description or write that in the docstring. At least the current example is very misleading, I've always assumed that I just need to set the description at docstring, but it actually also needs |
honestly I did too.. 🤦 I think it should just "do the obvious thing" here.. |
@longcw do you wanna take a stab at making it the default behavior? |
@davidzhao sure, updated. |
@llm.ai_callable
need a explicitdescription=llm.USE_DOCSTRING
to use the docstring as the description.