Skip to content

Temp workaround for langfuse otel traces #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
longcw merged 4 commits into from
Nov 24, 2025
Merged

Temp workaround for langfuse otel traces #3987

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f899de4
temp workaround
chenghao-mou Nov 18, 2025
8c3d783
fix session span activation
chenghao-mou Nov 19, 2025
515a129
detach in start
chenghao-mou Nov 19, 2025
ee94a58
skip span activation for pause&resume
chenghao-mou Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions livekit-agents/livekit/agents/voice/agent_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ def __init__(
self._agent_speaking_span: trace.Span | None = None
self._session_span: trace.Span | None = None
self._root_span_context: otel_context.Context | None = None
self._session_ctx_token: otel_context.Token | None = None

self._recorded_events: list[AgentEvent] = []
self._enable_recording: bool = False
Expand Down Expand Up @@ -523,6 +524,13 @@ async def start(
pass

self._session_span = current_span = tracer.start_span("agent_session")
# we detach here to avoid context issues since tokens need to be detached
# in the same context as it was created
if self._session_ctx_token is not None:
otel_context.detach(self._session_ctx_token)
self._session_ctx_token = None
ctx = trace.set_span_in_context(current_span)
self._session_ctx_token = otel_context.attach(ctx)

self._recorded_events = []
self._room_io = None
Expand Down
Loading