-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Restore otel chat message #4118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The tricky thing is how we're going to handle PII on a lot of different places in the future |
If we do PII redaction inside the |
|
The PII isn't realtime, it's going to be done at the end of the session. (On LiveKit Cloud) |
|
I see. But currently, we are still reporting LLM output, which might also contain PII. Do we intend to:
Either way, this would create a discrepancy between Agent Observability and Otel traces for the moment. If we are going to support Otel PII handling eventually, I think we should at least provide consistency for now, especially considering users have to explicitly set up Otel today. I like how Logfire handles this by:
|
theomonnom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, consistency for now makes sense
* main: (267 commits) AGT-2328: negative threshold in silero (livekit#4228) disable interruptions for agent greeting (livekit#4223) feature: GPT-5.2 support (livekit#4235) turn-detector: remove english model from readme (livekit#4233) add keep alive task for liveavatar plugin (livekit#4231) feat(warm-transfer): add sip_number parameter for outbound caller ID (livekit#4216) fix blocked send task in liveavatar plugin (livekit#4214) clear _q_updated right after await to avoid race conditions (livekit#4209) ensure playback_segments_count is consistent in the audio output chain (livekit#4211) fix inworld punctuation handling (livekit#4215) Inference: Rename fallback model name param (livekit#4202) fix race condition when stop background audio play handle (livekit#4197) fix watchfiles prevent agent prcoess exit on sigterm (livekit#4194) feat(google): add streaming support for Gemini TTS models (livekit#4189) Add LiveAvatar Stop Session API Call + README Fix (livekit#4195) Fallback API for Inference (livekit#4099) feat(rime): expand update_options to accept all TTS parameters (livekit#4095) mistralai models update (livekit#4156) fix record.exc_info is not pickable when using LogQueueHandler (livekit#4185) Restore otel chat message (livekit#4118) ...
Add back otel messages from
chat_ctx.This should close #4116 and the comment