Add support for thought processing in Google LLM (#4190) #4191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
I think #4170 is a better solution. So we keep the thought tokens in a separate field |
davidzhao
reviewed
Dec 18, 2025
livekit-plugins/livekit-plugins-google/livekit/plugins/google/llm.py
Outdated
Show resolved
Hide resolved
Author
I synced my branch with those changes to use the new extra field in |
Store the actual thinking text in delta.extra['google']['thinking'] instead of using an 'is_thought' boolean flag. Strip thinking tokens from main content.
Fixes code formatting in llm.py to comply with ruff rules. Changes include: - Better formatting of multi-line dictionaries - Correct spacing in assignments - Consistent function parameter formatting
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #4190