Skip to content

ensure playback_segments_count is consistent in the audio output chain #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
longcw merged 1 commit into from
Dec 10, 2025
Merged

ensure playback_segments_count is consistent in the audio output chain #4211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions livekit-agents/livekit/agents/voice/recorder_io/recorder_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,9 @@ def on_playback_finished(
self._reset_pause_state()

async def capture_frame(self, frame: rtc.AudioFrame) -> None:
if self.next_in_chain:
await self.next_in_chain.capture_frame(frame)

await super().capture_frame(frame)

if self.__recording_io.recording:
Expand All @@ -431,9 +434,6 @@ async def capture_frame(self, frame: rtc.AudioFrame) -> None:

self.__acc_frames.append(frame)

if self.next_in_chain:
await self.next_in_chain.capture_frame(frame)

def flush(self) -> None:
super().flush()

Expand Down
6 changes: 1 addition & 5 deletions livekit-agents/livekit/agents/voice/transcription/synchronizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,17 +507,15 @@ def __init__(
)
self._next_in_chain: io.AudioOutput = next_in_chain # redefined for better typing
self._synchronizer = synchronizer
self._capturing = False
self._pushed_duration: float = 0.0

async def capture_frame(self, frame: rtc.AudioFrame) -> None:
# using barrier() on capture should be sufficient, flush() must not be called if
# capture_frame isn't completed
await self._synchronizer.barrier()

self._capturing = True
await super().capture_frame(frame)
await self._next_in_chain.capture_frame(frame) # passthrough audio
await super().capture_frame(frame)
self._pushed_duration += frame.duration

if not self._synchronizer.enabled:
Expand Down Expand Up @@ -545,12 +543,10 @@ def flush(self) -> None:
self._synchronizer.rotate_segment()
return

self._capturing = False
self._synchronizer._impl.end_audio_input()

def clear_buffer(self) -> None:
self._next_in_chain.clear_buffer()
self._capturing = False

# this is going to be automatically called by the next_in_chain
def on_playback_finished(
Expand Down
Loading