Skip to content

fix blocked send task in liveavatar plugin #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinalenguyen merged 1 commit into from
Dec 10, 2025
Merged

fix blocked send task in liveavatar plugin #4214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions livekit-plugins/livekit-plugins-liveavatar/livekit/plugins/liveavatar/avatar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ def on_agent_state_changed(ev):
if ev.new_state == "idle":
self.send_event({"type": "agent.stop_listening", "event_id": str(uuid.uuid4())})

@self._agent_session.on("close")
def on_agent_session_close(ev):
self._msg_ch.close()
Copy link
Member

@chenghao-mou chenghao-mou Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can close it at the end of _send_task or the final finally: block.

Copy link
Member

@chenghao-mou chenghao-mou Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the issue, I think the change makes sense.


self._audio_buffer = QueueAudioOutput(sample_rate=SAMPLE_RATE)
await self._audio_buffer.start()
self._audio_buffer.on("clear_buffer", self._on_clear_buffer)
Expand Down
Loading