add interruption timeout to SpeechHandle #4218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for task in self._tasks: | ||
| task.cancel() | ||
| if self._generations: | ||
| self._mark_generation_done() |
Member
There was a problem hiding this comment.
nitpicking: we don't need these two lines, right? They are also called in _mark_done.
| self._interrupt_fut.set_result(None) | ||
|
|
||
| def _on_timeout() -> None: | ||
| logger.error( |
Member
There was a problem hiding this comment.
Do we need to check the done state again here?
Contributor
Author
There was a problem hiding this comment.
both _mark_done and the timeout handle are sync method, the _on_timeout is only called when _mark_done isn't called.
chenghao-mou
approved these changes
Dec 10, 2025
Member
chenghao-mou
left a comment
chenghao-mou
left a comment
There was a problem hiding this comment.
LGTM! Minor duplication from the first comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add interruption timeout to SpeechHandle, cancel the tasks of the speech and mark it as done if it's not done before the timeout, to avoid any potential deadlock that waiting for the speech playout.