Fix #4188: Prevent LogQueueListener crash when logging RpcError #4222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinyanna10
commented
Dec 11, 2025
nithinyanna10
commented
- Add _safe_to_log() helper to convert RpcError objects to pickleable dicts
- Sanitize custom log record attributes before pickling
- Add regression tests to verify RpcError handling
- Prevents pickle.PicklingError when RpcError objects are in log extra fields
- Add _safe_to_log() helper to convert RpcError objects to pickleable dicts - Sanitize custom log record attributes before pickling - Add regression tests to verify RpcError handling - Prevents pickle.PicklingError when RpcError objects are in log extra fields
|
|
Contributor
|
it's already fixed in #4185 |
- Remove trailing whitespace on lines 17 and 141 in log_queue.py - Remove unused imports (pickle, threading) from test_log_queue_rpcerror.py - Stub out openai.AsyncClient in test_summarize to prevent real API calls - Add monkeypatch fixture to test_summarize to use dummy client - Patch openai package AsyncClient to prevent network calls in LLM
nithinyanna10
force-pushed
the
fix/4188-logqueue-rpcerror
branch
from
fb2756d to
141099a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.