playback started call for DataStreamAudioOutput and QueueAudioOutput #4570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs introduced by #4131 and it should close #4568 affecting version 1.3.11
DataStreamAudioOutputandQueueAudioOutputwhere first frame future was never resolved, leading to agent messages missed in context and session hooks.More details:
We have 7 AudioOutput subsclasses:
Internal classes and the recorder will not fire
on_playback_startedevents since other output on the chain should take care of that. We don't put this in the base class because we want to make sure it is only fired as close to the device as possible.Summary by CodeRabbit
New Features
Changes
✏️ Tip: You can customize this high-level summary in your review settings.