Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added plugin for smallest.ai tts models #890

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

hamees-sayed
Copy link

I have added support for the non streaming and non auto regressive model by smallest.ai, following the existing TTS structure in adjacent plugins.

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 085c0a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

@theomonnom
Copy link
Member

Hey, thanks for your PR, do you think we could get an API key so we can add this new TTS to our tests?

@hamees-sayed
Copy link
Author

Hey @theomonnom you can get the api key from here https://waves.smallest.ai/apikeys

@hamees-sayed
Copy link
Author

Hi @theomonnom! Just checking if you had a chance to add smallest's TTS to the tests?

@hamees-sayed
Copy link
Author

the error seems to be failing because of missing elevanlabs tts key?

@prashantmetadome
Copy link

@hamees-sayed Thank you for your PR. I integrated it in my local fork of livekit but I am getting the following error in the integration of smallest ai TTS. Kindly help.

samples = np.frombuffer(self._initial_buffer, dtype=np.int16) ValueError: buffer size must be a multiple of element size

Note: It was working till day before yesterday.

@hamees-sayed
Copy link
Author

@prashantmetadome the new changes should fix it
@theomonnom any status on when this could be merged or if I have to make any changes?

@theomonnom
Copy link
Member

I'll create a ticket internally for it, thanks!

@hamees-sayed
Copy link
Author

hey @theomonnom can you please approve the workflow, i have fixed the ruff formatting issue

@hamees-sayed
Copy link
Author

i am so sorry for pinging you so much @theomonnom but i think now it should do it i have also smallest in readme and workflow

@theomonnom
Copy link
Member

i am so sorry for pinging you so much @theomonnom but i think now it should do it i have also smallest in readme and workflow

Nice thank you, we'll create a key and add it to our secrets before merging

@hamees-sayed
Copy link
Author

Hey @theomonnom I have tested the pytest module and github workflow and everything's passing on my end, can you please approve the workflow here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants