-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use cases to cameraX createCameraProvider #536
Conversation
🦋 Changeset detectedLatest commit: 4ddcc6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
Please run |
Thanks, I signed the CLA but the problem is that my commits are saying unverified. I'm working to fix it and push shortly. |
Hey @KasemJaffer, I think the issue is that the emails for your older commits are still in the wrong format, for example
The quotes within the There's a quick guide on how to amend the author field here, under the interactive rebase section. I highly suggest creating a separate branch to save a copy of the work before doing an interactive rebase, especially if you're not familiar with it since it can drop commits entirely. You can also just do it in another branch and open up a separate PR with the fixed commits. |
39136d3
to
4ddcc6e
Compare
You were right! thanks for the tip. All fixed up now. |
This allows you to take a high quality picture without interrupting the video stream.