Skip to content

Fix thread visibility issues in SignalClient #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 1 commit into from
Dec 16, 2025
Merged

Fix thread visibility issues in SignalClient #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-signal-client-volatile.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"client-sdk-android": patch
---

Fix thread visibility issues in SignalClient that could cause messages to be silently dropped.
5 changes: 5 additions & 0 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/SignalClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,14 @@ constructor(
private val ioDispatcher: CoroutineDispatcher,
private val networkInfo: NetworkInfo,
) : WebSocketListener() {
@Volatile
var isConnected = false
private set

@Volatile
private var currentWs: WebSocket? = null

@Volatile
private var isReconnecting: Boolean = false
var listener: Listener? = null
internal var serverVersion: Semver? = null
Expand Down