Sxian/clt 2315/implement sdl media manager hookup audio video streams#12
Conversation
| RoomInfoData room_info() const; | ||
|
|
||
| // Get the local participant. | ||
| // |
There was a problem hiding this comment.
Should these use /// so they can be picked up by the documentation generator later?
There was a problem hiding this comment.
good point, fix now.
| static_cast<uint64_t>(track->ffi_handle_id())); | ||
| new_audio_stream->set_sample_rate(options_.sample_rate); | ||
| new_audio_stream->set_num_channels(options.num_channels); | ||
| // TODO, sample_rate and num_channels are not useful in AudioStream, remove it |
There was a problem hiding this comment.
Could you please elaborate on what you mean by this? If this is the case, we can mark the fields as deprecated in the FFI Protobuf definition.
There was a problem hiding this comment.
This is what I found when implementing the AudioStream:
In the Rust implementation, AudioStream acts as a container that gathers audio buffers from the underlying audio track. Each audio buffer provided by the track already has its own sample_rate and num_channels.
The AudioStream simply exposes these buffers through its read() function, it does not resample the audio buffer to respect or enforce the sample_rate or num_channels specified when initializing the AudioStream.
That said, I think it’s correct that AudioStream does not include a built-in resampler, since that would introduce unnecessary performance overhead. However, in that case, it shouldn’t accept sample_rate or num_channels as initialization parameters.
xianshijing-lk
deleted the
sxian/CLT-2315/implement_sdl_media_manager_hookup_audio_video_streams
branch
3 participants
This implement the sdl_media_manager, sdl_media, sdl_video_renderer that can do the audio / video capturing and rendering.
And this PR also hooks it up with our SDK