Conversation
ladvoc
approved these changes
Dec 6, 2025
src/room.cpp
Outdated
| return; | ||
| } | ||
| auto local_handle = local_participant_->ffiHandleId(); | ||
| if (local_handle == 0 || rpc.local_participant_handle() != |
There was a problem hiding this comment.
nitpick: Maybe defining a constant (i.e., FFI_HANDLE_INVALID) would clarify what this check does?
Collaborator
Author
There was a problem hiding this comment.
done, I can use INVALID_HANDLE
src/room.cpp
Outdated
| // First, handle RPC method invocations (not part of RoomEvent). | ||
| if (event.message_case() == FfiEvent::kRpcMethodInvocation) { | ||
| const auto &rpc = event.rpc_method_invocation(); | ||
| std::cout << "kRpcMethodInvocation \n"; |
Collaborator
Author
There was a problem hiding this comment.
Done with removing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement the RPC features and a SimpleRpc example
To run the SimpleRpc example, you will need to
run local dev server
livekit-server --dev
generate tokens for caller, greeting and math-genius
lk token create -r test -i caller --join --valid-for 99999h --dev --room=robot
lk token create -r test -i greeter --join --valid-for 99999h --dev --room=robot
lk token create -r test -i math-genius --join --valid-for 99999h --dev --room=robot
build the example
./build.sh debug
run the example in 3 terminals:
./build/examples/SimpleRpc ws://127.0.0.1:7880 $TOKEN --role=caller (--role=greeter, --role=math-genius)