Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: web/native device consistency management #243

Merged
merged 12 commits into from
Mar 7, 2023
Merged

feat: web/native device consistency management #243

merged 12 commits into from
Mar 7, 2023

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Feb 23, 2023 •
edited
Loading

Add a device management method for Room to set the device audio output/input, and video input, and save the changes in roomOptions
with the following changes

  1. Consistency audio input/output settings for native/web
  2. Save speakerOn state for mobile devices.

@cloudwebrtc cloudwebrtc mentioned this pull request Feb 23, 2023
Closed
@cloudwebrtc cloudwebrtc changed the title fix: Force audio settings to be consistent. feat: web/native device consistency management Mar 6, 2023
@cloudwebrtc cloudwebrtc marked this pull request as ready for review March 6, 2023 13:41
@cloudwebrtc cloudwebrtc requested a review from davidzhao March 6, 2023 13:41
davidzhao
davidzhao approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!!

@cloudwebrtc cloudwebrtc merged commit db2e25d into main Mar 7, 2023
@cloudwebrtc cloudwebrtc deleted the fix/ios-audio-management branch March 7, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @davidzhao