Avoid using class scope for timers (#558)

* avoid using class scope for timers * fix copy paste error * protocol
livekit · Jan 23, 2023 · f96c339 · f96c339
1 parent 100ac49
commit f96c339
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/protocol b/protocol
diff --git a/src/room/timers.ts b/src/room/timers.ts
@@ -4,11 +4,13 @@
  * that the timer fires on time.
  */
 export default class CriticalTimers {
-  static setTimeout = setTimeout;
+  // eslint-disable-next-line @typescript-eslint/no-implied-eval
+  static setTimeout = (...args: Parameters<typeof setTimeout>) => setTimeout(...args);
 
-  static setInterval = setInterval;
+  // eslint-disable-next-line @typescript-eslint/no-implied-eval
+  static setInterval = (...args: Parameters<typeof setInterval>) => setInterval(...args);
 
-  static clearTimeout = clearTimeout;
+  static clearTimeout = (...args: Parameters<typeof clearTimeout>) => clearTimeout(...args);
 
-  static clearInterval = clearInterval;
+  static clearInterval = (...args: Parameters<typeof clearInterval>) => clearInterval(...args);
 }
+9 −10		go.mod
+20 −25		go.sum
+58 −36		livekit/livekit_analytics.pb.go
+225 −214		livekit/livekit_egress.pb.go
+143 −141		livekit/livekit_egress.twirp.go
+91 −81		livekit/livekit_ingress.pb.go
+61 −60		livekit/livekit_ingress.twirp.go
+390 −105		livekit/livekit_internal.pb.go
+547 −430		livekit/livekit_models.pb.go
+594 −480		livekit/livekit_rtc.pb.go
+7 −0		livekit_analytics.proto
+11 −10		livekit_egress.proto
+1 −0		livekit_ingress.proto
+28 −2		livekit_internal.proto
+9 −0		livekit_models.proto
+9 −0		livekit_rtc.proto
+17 −5		logger/config.go
+147 −37		logger/logger.go
+19 −0		redis/redis.go
+1 −1		utils/id.go