Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger kind type for Tracks to improve processor support #1033

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Feb 16, 2024

this makes kind of Tracks readonly and makes it easier to deal with different options needed for different processor types (e.g. video vs. audio).

This should not break any existing types.

Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: d8964ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from davidzhao February 16, 2024 09:59
Copy link
Contributor

github-actions bot commented Feb 16, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 81.21 KB (+0.03% 🔺)
dist/livekit-client.umd.js 86.8 KB (+0.03% 🔺)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukasIO lukasIO merged commit 8b031b0 into main Feb 19, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/stronger-track-type branch February 19, 2024 08:58
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants