Only perform mute/unmute actions if necessary #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 968e6b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…client-sdk-js into lukas/skip-unnecessary-restarts
lukasIO
commented
Feb 27, 2024
| @@ -133,6 +138,11 @@ export default class LocalVideoTrack extends LocalTrack<Track.Kind.Video> { | |||
| async unmute(): Promise<typeof this> { | |||
| const unlock = await this.muteLock.lock(); | |||
| try { | |||
| if (!this.isMuted) { | |||
There was a problem hiding this comment.
we could add a check here for mediaStreamTrack.readyState === 'live' just to make sure?
There was a problem hiding this comment.
I think it is fine to leave it out. If it not live, it is ended and the following action is probably not user perceptible any way. Want to avoid checks which probably increases the surface area of browser weirdness affecting functionality in unexpected ways.
davidzhao
approved these changes
Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restarting tracks seemingly takes a lot longer on new Safari versions (>=17.3.1).
This tries to minimise that impact by avoiding unnecessary restarts to tracks.
Previously calling
unmuterepeatedly would have led to multiple track restarts even if the track is unmuted already.