-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't create data channel of publisher until sending data message #1118
Conversation
🦋 Changeset detectedLatest commit: 8ed27d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! But, I think this requires a protocol version bump to ensure backwards compatibility.
Also, all clients need to do this to take advantage of this optimisation right?
src/room/RTCEngine.ts
Outdated
@@ -1165,6 +1172,14 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit | |||
} | |||
|
|||
this.pcManager.requirePublisher(); | |||
// don't negotiate without any trascenvers or data channel, it will generate sdp without ice frag then negotiate failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:nit: transceivers
This is a client change so protocol bump doesn't work for it, the new server can work with old/new clients.
Right |
what does that mean in terms of backwards compatibility of a client with this change trying to connect to an older server verison? |
The publisher peerconnection will be considered as failed by sfu. |
^ this has been done, but might have been unneeded as this PR only checks for server side protocol version. |
Will not merge this change until sfu server with livekit/livekit#2686 updated as the old server version always requires data channelEnable this optimization if server supports optional publisher datachannel (protocol > 13)