Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transcription handling #1119

Merged
merged 12 commits into from
May 3, 2024
Merged

Add support for transcription handling #1119

merged 12 commits into from
May 3, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Apr 26, 2024

No description provided.

@lukasIO lukasIO requested a review from davidzhao April 26, 2024 13:32
Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 8b2c6b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 26, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 79.51 KB (+0.45% 🔺)
dist/livekit-client.umd.js 85.18 KB (+0.44% 🔺)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/room/Room.ts Show resolved Hide resolved
src/room/types.ts Show resolved Hide resolved
@lukasIO lukasIO requested a review from davidzhao April 29, 2024 13:39
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidzhao
Copy link
Member

awesome!

@lukasIO lukasIO merged commit a087e03 into main May 3, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/transcriptions branch May 3, 2024 06:39
@github-actions github-actions bot mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants