Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep backwards compatibility for attributes updates on creation #1350

Closed
wants to merge 1 commit into from

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 9, 2024

follow up for #1344 to keep backwards compatibility

@lukasIO lukasIO requested a review from davidzhao December 9, 2024 18:02
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: d0939b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 9, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 86.48 KB (+0.03% 🔺)
dist/livekit-client.umd.js 92.63 KB (+0.03% 🔺)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we need this level of compat? the previous behavior seems incorrect. (we don't trigger similar events for metadata upon connect)

@lukasIO lukasIO marked this pull request as draft December 9, 2024 20:47
@lukasIO lukasIO closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants