Fix missed TrackPublished events. #275
Conversation
When initial participant info is sent down along with tracks, we would miss emitting TrackPublished events for them. This is due an incorrect assumption that participants would first join without tracks. Instead of relying on if it's the first update, we now use Room connection state to determine if those TrackPublished events should be emitted or not.
davidzhao
requested review from
davidliu,
hiroshihorie,
lukasIO,
theomonnom and
cloudwebrtc
🦋 Changeset detectedLatest commit: 3c65d06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
found a related bug that I'm fixing together. protocol 8 causes us to fire TrackSubscribed prior to Room connection state going to connected. |
|
One small thing is that other participant events might fire from updating the info. When implementing for android, participant metadata event fired for me. |
Yeah, I've noticed that too. will fix that too before merging. |
| // technically subscribed. | ||
| // We'll defer these events until when the room is connected or eventually disconnected. | ||
| if (this.state === ConnectionState.Connecting || this.state === ConnectionState.Reconnecting) { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
@davidzhao If it is to ensure that the track can be rendered (can receive RTP) when onTrackAdded is triggered, would it be more accurate to listen iceConnectionState instead of delaying 10 ms?
There was a problem hiding this comment.
right, more precisely, we can wait for ConnectionStateChanged event, and trigger the update when it flips to Connected.
When initial participant info is sent down along with tracks, we would
miss emitting TrackPublished events for them. This is due an incorrect
assumption that participants would first join without tracks.
Instead of relying on if it's the first update, we now use Room connection
state to determine if those TrackPublished events should be emitted or not.