Fix handling of permissions after resubscribe #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user subscribes a track, but then have permission revoked. The revoked state may be cached even when permissions are granted afterwards. Since subscription is an indicator that a user is allowed to subscribe to a track. We'll flip _allowed to true on subscribe.
🦋 Changeset detectedLatest commit: 070739b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
requested review from
lukasIO and
boks1971
and removed request for
lukasIO
boks1971
approved these changes
Jun 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user subscribes a track, but then have permission revoked. The
revoked state may be cached even when permissions are granted afterwards.
Since subscription is an indicator that a user is allowed to subscribe
to a track. We'll flip _allowed to true on subscribe.