keep mediastream id for migration #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a4a55f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
reviewed
Jun 29, 2022
| @@ -47,6 +49,7 @@ export class Track extends (EventEmitter as new () => TypedEventEmitter<TrackEve | |||
| super(); | |||
| this.kind = kind; | |||
| this._mediaStreamTrack = mediaTrack; | |||
| this._mediaStreamID = mediaTrack.id; | |||
There was a problem hiding this comment.
should _mediaStreamID also get set when replaceTrack is called or is it ok to always use the one which was used to create the track?
There was a problem hiding this comment.
it should be ok to always use the create one, since replace track will not cause reneogtiation, so id in sdp is unchanged.
lukasIO
approved these changes
Jun 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mediastream.id might change during unmute/mute, when migration involved, the changed stream id might cause server side can't find the destination track or find a incorrect one, so keep it when Track construct and used in SyncState for migration