Add fallback for addTrack if addTransceiver is not supported by a device
#403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 97b14d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
reviewed
Aug 18, 2022
src/room/RTCEngine.ts
Outdated
| return this.createTransceiverRTCRtpSender(track, opts, encodings); | ||
| } | ||
| if (supportsAddTrack()) { | ||
| console.log('using add-track fallback'); |
| @@ -577,7 +567,7 @@ export default class LocalParticipant extends Participant { | |||
| this.engine.negotiate(); | |||
|
|
|||
| // store RTPSender | |||
| track.sender = transceiver.sender; | |||
| track.sender = await this.engine.createSender(track, opts, encodings); | |||
There was a problem hiding this comment.
I think this will need to happen before this.engine.negotiate() and setTrackCodecBitrate. tho today this works because of the debounce logic that we have in place.
cnderrauber
approved these changes
Aug 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the work in this PR is largely based upon the work in #373 (thank you @cscherban !)
main difference implementation wise is that there's no support for
addStream.apart from that it's mostly refactoring.
To increase compatibility further, we will have to add some more specific browser targets to the babel transpilation (will open a separate PR for that).
note: using
addTrackcurrently breaks dynacast as this check is failing https://github.com/livekit/client-sdk-js/blob/main/src/room/track/LocalVideoTrack.ts#L322