Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local participant events being disabled before all local tracks are unpublished #462

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

KallynGowdy
Copy link
Contributor

Fixes #461

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

🦋 Changeset detected

Latest commit: b72546d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching & fixing this 🙏

@davidzhao davidzhao merged commit 5024e26 into livekit:main Oct 3, 2022
@github-actions github-actions bot mentioned this pull request Oct 3, 2022
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Oct 4, 2022
…re unpublished (livekit#462)

* Fix local participant events being disabled before all local tracks are unpublished

* added changeset

Co-authored-by: David Zhao <dz@livekit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoomEvent.LocalTrackUnpublished events are not sent when disconnecting a Room
3 participants