Add audio analyser util function #515
Conversation
🦋 Changeset detectedLatest commit: 361a891 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
example/sample.ts
Outdated
| const { calculateVolume } = createAudioAnalyser(track); | ||
|
|
||
| setInterval(() => { | ||
| console.log(calculateVolume()); |
There was a problem hiding this comment.
nit: this would seem pretty noisy in the console. maybe less frequently or as a bonus, hooking it up to a jank meter?
| * Additionally returns a convenience method `calculateVolume` to perform instant volume readings on that track. | ||
| * Call the returned `cleanup` function to close the audioContext that has been created for the instance of this helper | ||
| */ | ||
| export function createAudioAnalyser( |
There was a problem hiding this comment.
should we handle track attachment bug in here? i.e. log a warning if it's not yet attached.
There was a problem hiding this comment.
In my tests, the attachment didn't matter. I had a separate path for RemoteTracks initially that would have handled this case, but it turns out it also works for the analysing use case without any attachments!
* add audio analyser * convert to util function * add comment * cleanup * more comments * update import * add vu meter in example, give option to clone track when creating analyser * revert room options * changeset
* add audio analyser * convert to util function * add comment * cleanup * more comments * update import * add vu meter in example, give option to clone track when creating analyser * revert room options * changeset
* add audio analyser * convert to util function * add comment * cleanup * more comments * update import * add vu meter in example, give option to clone track when creating analyser * revert room options * changeset
No description provided.