Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-native client info #629

Merged
merged 6 commits into from
Mar 27, 2023
Merged

React-native client info #629

merged 6 commits into from
Mar 27, 2023

Conversation

davidliu
Copy link
Contributor

No description provided.

@davidliu davidliu requested a review from lukasIO March 23, 2023 15:58
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2023

🦋 Changeset detected

Latest commit: 8ef78a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidliu
Copy link
Contributor Author

@lukasIO Changed to using navigator.product, but no luck on the navigator.platform for detecting the OS. :(

src/room/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
and thank you 🙂

@davidliu davidliu merged commit cb380c2 into main Mar 27, 2023
@davidliu davidliu deleted the dl/rn_sdk_os branch March 27, 2023 15:43
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants