Fix svc mode for chrome v113, change default svc mode to L3T3_KEY #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix svc mode for chrome v113.
Add closable spatial layer for svc dynacast but disable it as two
blur/frozen issues
with current server/client:
1. chrome 113: when switching to up layer with scalability Mode change, it will generate a
low resolution frame and recover very quickly, but noticable
2. livekit sfu: additional pli request cause video frozen for a few frames, also noticable
🦋 Changeset detectedLatest commit: 901315e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
davidzhao
approved these changes
May 30, 2023
| } | ||
| case 'L3T3_KEY': | ||
| encodings.push({ | ||
| rid: videoRids[2], |
There was a problem hiding this comment.
what if there are only two layers specified ? and does it retain compatibility with Chrome < 113?
There was a problem hiding this comment.
We only provide 3 layers in the publish options now. And for Chrome version < 113, I had not tested it yet but am afraid that it is broken in the early version as the API change.
This was referenced May 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix svc mode for chrome v113.
Change default svc mode to L3T3_KEY as same as google meet. It reduces ~30% CPU load when encoding 720p videos.
Add closable spatial layer for svc dynacast but disable it now for two blur/frozen issues
with current server/client:
low resolution frame and recover very quickly, but noticable