Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use active device when publishing a new track #757

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jun 28, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

🦋 Changeset detected

Latest commit: 970019e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested review from davidzhao and Ocupe June 28, 2023 17:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 83.09 KB (+0.02% 🔺)
dist/livekit-client.umd.js 87.22 KB (+0.02% 🔺)

default:
break;
}
if (deviceKind) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be set only if activeDeviceMap contains the device?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, yes!

src/room/participant/LocalParticipant.ts Show resolved Hide resolved
@lukasIO lukasIO merged commit bc77e98 into main Jun 29, 2023
@lukasIO lukasIO deleted the lukas/propagate-active-device branch June 29, 2023 08:16
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants