Update dimensions when the remote track is detached #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90ce2fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
hi @burzomir , Instead of calling it in |
|
@lukasIO I've updated the code. Please, take a look. |
lukasIO
reviewed
Jul 5, 2023
davidliu
approved these changes
Jul 5, 2023
davidliu
reviewed
Jul 5, 2023
elementInfos are already filtered inside of stopObservingElementInfo method
|
this is looking great, thanks @burzomir ! |
This was referenced Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidzhao @lukasIO
Use case for this change:
There are two video elements in the UI. The first is small (480x320) and placed in a participant grid. The second is big (1280x720) and only displays the active speaker. When no one is speaking, then the second video element is removed. In this case, I want to use only the low-resolution simulcast layer. Currently, simulcast layers change only on resize and visibility change events or when a remote track is attached.