Debounce mediastreamtrack mute events #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c36ebe8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
davidzhao
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
lgtm!
I tested a few different scenarios. I think muted handling is still needed because sometimes when the computer is put to sleep (closing MacBook cover), Safari still keeps the session and device active. to the other party, it could look like a black tile.
This is a good change to avoid flopping though.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OBS virtual cameras (and reportedly also other devices)
mediastreamtrackmutedevents get emitted in a regular interval, followed byunmuteevents.In order to avoid this resulting in a constant
pauseUpstream->resumeUpstreamloop, we debounce themuteevent so that we only pick it up if the track has been muted consistently for > 5s.