Improve handling of incompatible published codecs #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client publishes a codec that the server doesn't support (or if server determines the client isn't compatible with it), we would reject those track publications. However, the better thing to do from a user experience standpoint is to publish with another compatible codec. This PR requires v1.5.1
🦋 Changeset detectedLatest commit: 11da5e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
cnderrauber
reviewed
Oct 27, 2023
lukasIO
approved these changes
Oct 27, 2023
| log.debug( | ||
| `primary codec ${opts.videoCodec} not supported, fallback to ${backupCodec.codec}`, | ||
| if (primaryCodecMime && track.kind === Track.Kind.Video) { | ||
| const updatedCodec = primaryCodecMime.replace(/video\//y, '').toLowerCase(); |
There was a problem hiding this comment.
Just as a suggestion, we have a mimeTypeToVideoCodecString util function as part of e2ee, maybe makes sense to re-use here?
There was a problem hiding this comment.
awesome, this function is perfect. I've moved it to track/utils since it's now used outside of e2ee
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client publishes a codec that the server doesn't support (or if server determines the client isn't compatible with it), we would reject those track publications.
However, the better thing to do from a user experience standpoint is to publish with another compatible codec. This compatibility layer works with server v1.5.1+
This change will use the preferred codec as returned in TrackPublishedResponse. Client will update its state accordingly.
Tested: disabling VP8 and publishing VP8, H.264, and AV1, verified backup is chosen and publishing at expected bitrates.