Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getStats() to PCTransport #927

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

rnakano
Copy link
Contributor

@rnakano rnakano commented Nov 8, 2023

We used to manually collect and analyze PeerConnection stats like this:

room.engine.publisher.pc.getStats();

However, this became unavailable with the changes in #903, So, we wanted to add a way to call getStats() as an alternative.

Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: 82027e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Understand the requirement, just be aware that we're planning some more changes to internal modules in the coming weeks, so there might be additional changes you'll have to make in the near term future.

@rnakano
Copy link
Contributor Author

rnakano commented Nov 8, 2023

Got it, and thanks for the review!

@lukasIO lukasIO merged commit a8d5228 into livekit:main Nov 8, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
@rnakano rnakano deleted the add-get-stats branch November 8, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants