Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stopping old track in setMediaStreamTrack #980

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fix stopping old track in setMediaStreamTrack #980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a6af6e
Fix stopping old track in setMediaStreamTrack
mpnri Jan 1, 2024
5d8d46b
Create big-turkeys-lay.md
lukasIO Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/room/track/LocalTrack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,6 @@ export default abstract class LocalTrack extends Track {
this._mediaStreamTrack.removeEventListener('ended', this.handleEnded);
this._mediaStreamTrack.removeEventListener('mute', this.handleTrackMuteEvent);
this._mediaStreamTrack.removeEventListener('unmute', this.handleTrackUnmuteEvent);

if (!this.providedByUser && this._mediaStreamTrack !== newTrack) {
this._mediaStreamTrack.stop();
}
}

this.mediaStream = new MediaStream([newTrack]);
Expand Down Expand Up @@ -148,6 +144,11 @@ export default abstract class LocalTrack extends Track {
if (this.sender) {
await this.sender.replaceTrack(processedTrack ?? newTrack);
}
// if `newTrack` is different from the existing track, stop the
// older track just before replacing it
if (!this.providedByUser && this._mediaStreamTrack !== newTrack) {
this._mediaStreamTrack.stop();
}
this._mediaStreamTrack = newTrack;
if (newTrack) {
// sync muted state with the enabled state of the newly provided track
Expand Down
Loading