Remove OFF option from VideoQuality enum
#985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 649907d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
lukasIO
changed the title
OFF option from VideoQuality enumOFF option from VideoQuality enum
boks1971
approved these changes
Jan 3, 2024
src/room/track/Track.ts
Outdated
| switch (q) { | ||
| case ProtoQuality.HIGH: | ||
| case ProtoQuality.OFF: | ||
| return VideoQuality.HIGH; |
There was a problem hiding this comment.
Would this cause trouble? Should the last video quality be cached and used when OFF? This is tricky.
There was a problem hiding this comment.
that's a good point. Currently this mapping function isn't even used anywhere in the code base. I added it because we have a similar helper to convert ConnectionQuality to a string based enum.
We can also simply remove this for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.