Remove leaked renderers appeared on camera switch #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-niculescu
approved these changes
Oct 25, 2024
hiroshihorie
added a commit
that referenced
this pull request
Nov 6, 2024
commit 2e05b21 Author: hiroshihorie <548776+hiroshihorie@users.noreply.github.com> Date: Mon Oct 28 22:21:56 2024 +0900 v2.0.17 commit 86a8634 Author: hiroshihorie <548776+hiroshihorie@users.noreply.github.com> Date: Tue Oct 29 15:02:17 2024 +0900 Move parts of visualization code into components commit 027fea7 Author: hiroshihorie <548776+hiroshihorie@users.noreply.github.com> Date: Tue Oct 29 02:25:54 2024 +0900 rtc 125.6422.11 commit 26d7725 Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> Date: Mon Oct 28 00:43:37 2024 +0900 Audio visualization helpers (#474) commit 4a73d39 Author: hiroshihorie <548776+hiroshihorie@users.noreply.github.com> Date: Sun Oct 27 22:59:11 2024 +0900 swiftformat commit 04bf827 Author: Bogdan Vatamanu <vatamanu.bogdan41@gmail.com> Date: Sun Oct 27 15:57:21 2024 +0200 Remove leaked renderers appeared on camera switch (#507) Hello @hiroshihorie! I found that inside **VideoView** on the camera switch the previous **primaryRenderer** gets leaked because it's not removed from the view's hierarchy when the transition ends. See:  Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> commit 89a0fa2 Author: Bogdan Vatamanu <vatamanu.bogdan41@gmail.com> Date: Sun Oct 27 13:14:05 2024 +0200 Fix boundaries setting for "SampleBufferVideoRenderer" re-layouting (#506) Hello @hiroshihorie! I'm experiencing issues with the camera's front-to-back switch feature, which occasionally causes the video frame to be incorrectly oriented in landscape mode when it should be in portrait mode. To resolve this issue, I've found that it's essential to update the frame of the **AVSampleBufferDisplayLayer** after applying the transformation matrix. This is because the transformation matrix also rotates the frame, which can result in incorrect orientation if the frame is not updated accordingly. commit 5869cea Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> Date: Thu Oct 24 18:38:51 2024 +0900 Agent state property (#495) commit 62a70ea Author: hiroshihorie <548776+hiroshihorie@users.noreply.github.com> Date: Sun Oct 20 00:22:27 2024 +0900 Temporarily remove strict concurrency warnings commit 1c9a681 Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> Date: Sun Oct 20 00:06:47 2024 +0900 WebRTC 125.6422.10 (#502)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @hiroshihorie!
I found that inside VideoView on the camera switch the previous primaryRenderer gets leaked because it's not removed from the view's hierarchy when the transition ends.
See:
