Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make processor initialization work on track create #1039

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 4, 2024

prevents errors when trying to stringify the effect dependency when the options include a processor.
Also adds a videoProcessor prop for the PreJoin prefab which I used to confirm this is working as expected in the prejoin.tsx example.

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: d2b36a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@livekit/components-react Patch
@livekit/component-example-next Patch
@livekit/components-js-docs Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size
LiveKitRoom only 6.05 KB (+0.84% 🔺)
LiveKitRoom with VideoConference 29.82 KB (+0.2% 🔺)
All exports 36.53 KB (-0.21% 🔽)

@lukasIO lukasIO marked this pull request as ready for review December 8, 2024 12:12
@lukasIO lukasIO requested review from Ocupe and bcherry December 8, 2024 12:13
@lukasIO lukasIO changed the title wip make processor initialization work on track create Make processor initialization work on track create Dec 8, 2024
@lukasIO lukasIO merged commit ec41a93 into main Dec 11, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/processor-init branch December 11, 2024 18:41
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants